Skip to content

🎨Director-v0: Pass headers on /manifests call to let the registry know we accept all manifest versions #8241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

🎨Director-v0: Pass headers on /manifests call to let the registry know we accept all manifest versions #8241

merged 2 commits into from
Aug 21, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 21, 2025

What do these changes do?

#8240 was missing the addition of headers when calling /manifests endpoints. this materialized when accessing from local development stack to master.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Voyager milestone Aug 21, 2025
@sanderegg sanderegg self-assigned this Aug 21, 2025
@sanderegg sanderegg added the a:director issue related with the director service label Aug 21, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner August 21, 2025 09:27
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Aug 21, 2025
@sanderegg sanderegg requested a review from GitHK as a code owner August 21, 2025 09:27
@sanderegg sanderegg changed the title 🎨Director-v0: Pass headers on /manifests call to let the registry we accept all manifest versions 🎨Director-v0: Pass headers on /manifests call to let the registry know we accept all manifest versions Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.74%. Comparing base (5718eb4) to head (8a667bc).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5718eb4) and HEAD (8a667bc). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (5718eb4) HEAD (8a667bc)
unittests 31 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8241       +/-   ##
===========================================
- Coverage   88.08%   66.74%   -21.34%     
===========================================
  Files        1861      759     -1102     
  Lines       71706    35457    -36249     
  Branches     1301      175     -1126     
===========================================
- Hits        63161    23666    -39495     
- Misses       8154    11734     +3580     
+ Partials      391       57      -334
Flag Coverage Δ
integrationtests 63.98% <ø> (-0.01%) ⬇️
unittests 75.81% <33.33%> (-10.87%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.78% <ø> (-8.25%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director 75.81% <33.33%> (-0.61%) ⬇️
director_v2 78.15% <ø> (-12.77%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.13% <ø> (-2.92%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.74% <ø> (-29.40%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5718eb4...8a667bc. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 8a667bc.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

GitHK
GitHK approved these changes Aug 21, 2025
View reviewed changes
@sanderegg sanderegg force-pushed the registry/upgrade-to-v3-ensure-we-accept-all-kinds-of-manifests branch from 00fc41f to 8a667bc Compare August 21, 2025 09:52
@sanderegg sanderegg merged commit 1b85b28 into ITISFoundation:master Aug 21, 2025
3 of 4 checks passed
@sanderegg sanderegg deleted the registry/upgrade-to-v3-ensure-we-accept-all-kinds-of-manifests branch August 21, 2025 09:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

a:director issue related with the director service t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @GitHK @mrnicegyu11 @matusdrobuliak66